Skip to content

gh-106344 return ciphers in SSLSocket.shared_ciphers() after session reuse - #110902

Closed
kevinAlbs wants to merge 4 commits into
python:mainfrom
kevinAlbs:fix_shared_ciphers
Closed

kevinAlbs wants to merge 4 commits into
python:mainfrom
kevinAlbs:fix_shared_ciphers

Conversation

@kevinAlbs

@kevinAlbs kevinAlbs commented Oct 15, 2023 •

Copy link
Copy Markdown

Store client sent ciphers from the hello message. Revise SSLSocket.shared_ciphers() to return the intersection of client and server ciphers. This results in SSLSocket.shared_ciphers() returning ciphers after an SSL session is reused.

This is an alternative resolve: #106344

@bedevere-app

bedevere-app Bot commented Oct 15, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 14, 2026
@ambv

ambv commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

This PR is blocked on its author, has not been touched by a human in more than 2 years, and no longer merges cleanly. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer on gh-106344.

@ambv ambv closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSLSocket.shared_ciphers() does not document None is returned on session reuse

2 participants